[Asterisk-code-review] chan sip: Address runaway when realtime peers subscribe to ... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip:  Address runaway when realtime peers subscribe to mailboxes
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/3962/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 17206: 		sip_send_mwi_to_peer(peer, 0);
> Doing this without a reference is concerning to me.  What if the stasis eve
The destruction still does an unsubscribe_and_join which ensures the peer is valid. (I believe)


-- 
To view, visit https://gerrit.asterisk.org/3962
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07519ef7f092629e1e844f855abd279d6475cdd0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes