[Asterisk-code-review] Fix showing of swap details when sysinfo() is available (asterisk[master])

Walter Doekes asteriskteam at digium.com
Thu Sep 15 02:14:54 CDT 2016


Walter Doekes has posted comments on this change.

Change subject: Fix showing of swap details when sysinfo() is available
......................................................................


Patch Set 2: Code-Review+1

I would've swapped the order of defined(HAVE_SWAPCTL) || defined(HAVE_SYSINFO) because of how they are checked in the function.

And I probably would've preferred the removal of the dummy swapmode() call -- or add a #define SWAPMODE_IS_DUMMY there which could be checked here instead -- you still have to scroll through the file to verify correctness now.

But it's better than it was. Can't nitpick over everything ;)

-- 
To view, visit https://gerrit.asterisk.org/3871
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fb21dad8f27e416c60f138c6f2bff03fb626eca
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list