[Asterisk-code-review] astobj2: Header macro's should deal with error's from ao2 ref. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: astobj2: Header macro's should deal with error's from ao2_ref.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/3872/2/include/asterisk/astobj2.h
File include/asterisk/astobj2.h:

Line 570: 					__had_error_ ## __LINE__ = 1; \
> Rather than creating another variable, why not set
This would cause a compile error depending on the typeof(src).  For example if we have 'const struct ast_format *src' and try to do: ao2_replace(dst_codec, src->codec) - this would fail since typeof(src->codec) is a readonly pointer.


-- 
To view, visit https://gerrit.asterisk.org/3872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06d27fb6667f54c960023aa3b93d95b07147de
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes