[Asterisk-code-review] Binaural synthesis (confbridge): DTFM conference management. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: Binaural synthesis (confbridge): DTFM conference management.
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/3525/2//COMMIT_MSG
Commit Message:

PS2, Line 7: DTFM
DTMF

other places as well.


PS2, Line 11: * randomly reposition all participants in the conference (all channels).
Why the need to randomly reposition?


https://gerrit.asterisk.org/#/c/3525/2/apps/app_confbridge.c
File apps/app_confbridge.c:

PS2, Line 1990: 		struct confbridge_user *user, 
              : 		struct ast_bridge_channel *bridge_channel) 
More pesky whitespace. :)


PS2, Line 2004: 		struct confbridge_user *user, 
              : 		struct ast_bridge_channel *bridge_channel) 
and again.

These get me all the time.  Usually I bring up my patch in gerrit just after submitting to check if any snuck in.


https://gerrit.asterisk.org/#/c/3525/2/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

PS2, Line 1264: 	
pesky whitespace. :)


https://gerrit.asterisk.org/#/c/3525/2/apps/confbridge/include/confbridge.h
File apps/confbridge/include/confbridge.h:

PS2, Line 156: 	CONF_SOUND_BINAURAL_ON,
             : 	CONF_SOUND_BINAURAL_OFF,
             : 	CONF_SOUND_RANDOM_POS,
Although this isn't a public enum, you might want to place these at the end of the enum to keep the others from having their values shifted.  It'll also match the string field ordering.


-- 
To view, visit https://gerrit.asterisk.org/3525
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe708b9fe26097c1798fcbfcc4dc461267d8af8
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes