[Asterisk-code-review] Binaural synthesis (confbridge): On/off setting for binaural... (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: Binaural synthesis (confbridge): On/off setting for binaural synthesis.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/3523/2/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

PS2, Line 1928: static int binaural_active_handler(const struct aco_option *opt, struct ast_variable *var, void *obj) 
              : {
              : 	struct bridge_profile *b_profile = obj;
              : 
              : 	if (strcasecmp(var->name, "binaural_active")) {
              : 		return -1;
              : 	}
              : 	if (sscanf(var->value, "%30u", &b_profile->binaural_active) != 1) {
              : 		return -1;
              : 	}
              : 	if (b_profile->binaural_active == 0 || b_profile->binaural_active == 1) {
              : 		return 0;
              : 	}
              : 	return -1;
              : }
You don't need this at all if you use the OPT_BOOLFLAG_T type below.


Line 2198: 	aco_option_register_custom(&cfg_info, "binaural_active", ACO_EXACT, bridge_types, "0", binaural_active_handler, 0);
Change to OPT_BOOLFLAG_T.  See the comment in confbridge.h and look at "record_conference" below.


https://gerrit.asterisk.org/#/c/3523/2/apps/confbridge/include/confbridge.h
File apps/confbridge/include/confbridge.h:

Line 212: 	unsigned int binaural_active; /*!< TRUE if binaural is activated. */
Rather than adding another member, just add another entry to 
bridge_profile_flags.


-- 
To view, visit https://gerrit.asterisk.org/3523
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59dfcb8e55fe1df4ef32045882fea5bb58fc71db
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes