[Asterisk-code-review] Binaural synthesis (confbridge): interleaved two-channel audio. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: Binaural synthesis (confbridge): interleaved two-channel audio.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/3521/1//COMMIT_MSG
Commit Message:

Could you expand a little on the change?

Since this patch by itself has nothing to do with confbridge maybe explain why write and not read?

How you you use the new api?

etc.


https://gerrit.asterisk.org/#/c/3521/1/include/asterisk/translate.h
File include/asterisk/translate.h:

Line 213: 	int interleaved_stereo; 	/*!< indicates if samples are in interleaved order, for stereo lin */
Put this at the end of the structure so that if we ever want to cherry-pick this patch back to 13 or 14 we won't break ABI compatibility.


https://gerrit.asterisk.org/#/c/3521/1/main/channel.c
File main/channel.c:

Line 5516: 		trans_pvt = access->get_trans(chan);
We seem to do this a few places so maybe move this up before the "if ((ast_format_cmp(" statement and remove the one below.


Line 5544: 			trans_pvt->interleaved_stereo = 0;
Do we not care about read?


-- 
To view, visit https://gerrit.asterisk.org/3521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a547cea0fd3c6d1e502709d9e7e39605035757a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes