[Asterisk-code-review] res pjsip caller id.c: Truncate cid num at first semicolon. (asterisk[13])

Matt Jordan asteriskteam at digium.com
Fri Sep 9 10:57:01 CDT 2016


Matt Jordan has posted comments on this change.

Change subject: res_pjsip_caller_id.c: Truncate cid_num at first semicolon.
......................................................................


Patch Set 1:

> Since this is a user visible change, I think a CHANGES entry is
 > needed

I agree. People put weird things into the user portion - I know I've seen issues in the tracker before for people wanting newlines, tabs, and other unexpected things.

While I'm not necessarily against the change itself, I'm pretty sure someone out there is going to hate this. We might as well warn them up front.

-- 
To view, visit https://gerrit.asterisk.org/3846
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ad6bd64889af888358b12bde85563a040197f24
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list