[Asterisk-code-review] Fix showing of swap details when sysinfo() is available (asterisk[master])

[Walter Doekes]

Walter Doekes has posted comments on this change.

Change subject: Fix showing of swap details when sysinfo() is available
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I don't think this patch is correct.

I think it should be this instead:

```
#if (defined(HAVE_SYSCTL) && defined(HAVE_SWAPCTL)) || defined(HAVE_SYSINFO)
```

See:

http://infobot.rikers.org/%23asterisk-dev/20160705.html.gz

```
07:27.15	wdoekes	I think you have sysinfo too
07:27.16	snuff-work	i think its more the 'ifdef' around swap
07:27.20	wdoekes	yes
07:27.25	wdoekes	you don't have HAVE_SWAPCTL
07:27.32	wdoekes	so it needs the SYSCTL to show the values
07:27.32	snuff-work	yes..
07:28.00	snuff-work	but it doesn't.. because those values are calc either with SYSCTL OR SYSINFO
07:28.08	wdoekes	correct
07:28.30	wdoekes	should be SYSCTL&&SWAPCTL || SYSINFO
```

https://gerrit.asterisk.org/#/c/3871/1/main/asterisk.c
File main/asterisk.c:

Line 856: #if defined (HAVE_SYSCTL) || defined(HAVE_SWAPCTL) || defined(HAVE_SYSINFO)
This whole function is only defined if:

#if defined(HAVE_SYSINFO) || defined(HAVE_SYSCTL)

After this change, this ifdef makes no sense any more.


-- 
To view, visit https://gerrit.asterisk.org/3871
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fb21dad8f27e416c60f138c6f2bff03fb626eca
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes