[Asterisk-code-review] channel: Hang-up crashed Asterisk while freeing private data. (asterisk[11])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: channel: Hang-up crashed Asterisk while freeing private data.
......................................................................


Patch Set 2:

> the backtrace won't have this code location the stack

Mhm. The error message failed to explain this even to an experienced developer: With that change, an *interactive* GDB session is required to set a breakpoint to that code position manually. Then, the user can ask GDB for a backtrace. Consequently, the current message is not sufficient either.

Did someone look at the existing reports about this issue?

Some users might face this code position once in a month or once in a year. They might not report at all. Some might search on their own and fail because analyzing this is quite complex. Those who show-up on Jira might expect someone to take this issue over – especially because there is Digium, with all that ISO 9001, Quality Managers, and so on. Those who understand that it is *our* issue, asking those to re-configure/compile Asterisk in Developer Mode via ./configure --enable-dev-mode
make menuselect.makeopts
menuselect/menuselect --enable DONT_OPTIMIZE --disable COMPILE_DOUBLE --enable BETTER_BACKTRACES --enable DO_CRASH
and "dumpcore=yes" in /etc/asterisk/asterisk.conf
might not be feasible, because third-party additions might not be C90 compatible.

Furthermore, removing the original error message makes it impossible to find already existing reports. And I still wonder why this issue here was not tackled before. Only the cause was looked at, why this code here was reached.

All in all, I am not convinced that this change improves the overall situation. Therefore, I cannot continue on this matter and have to abandon my change-set here.

-- 
To view, visit https://gerrit.asterisk.org/3731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id085417d7e0a5c61382582e7d250b56ab3c00a1b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No