[Asterisk-code-review] chan sip: Don't refuse calls with "optional crypto"; fall ba... (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: chan_sip: Don't refuse calls with "optional crypto"; fall back to RTP.
......................................................................


Patch Set 1:

I am differentiating between accepting/refusing (SIP status 200 versus 488) and using/ignoring (SRTP versus RTP). chan_sip should accept RTP/AVP regardless whether there is a crypto attribute and/or an alternative RTP/sAVP profile in SDP. As of Asterisk 13.11.0 these two scenarios are not handled. Of course, to *use* the crypto attribute, the res_srtp module must be present.

Or stated differently: Simply ignore the first two sentences of my first reply. They do not add anything to this discussion. Initially, I thought this patch changes the case when res_srtp is not loaded as well and those two sentences were a starter to show the part I value.

The problem is, that this change now accepts RTP/AVP/crypto but does not use (and therefore does not reply with a) crypto attribute, when res_srtp is loaded. This means, Preferred sRTP is ignored although it could be leveraged. Furthermore, I have at least one implementation (Nokia Symbian/S60) which sends a BYE on this. Finally, ASTERISK-23989 is not addressed completely and should not be closed by this change, because
1) if res_srtp is not loaded but the
2) SDP contains RTP/sAVP/crypto + RTP/AVP (Acrobits Groundwire » Settings » Accounts » Advanced » Secure Calls » Outgoing Calls » Best Effort)
the INVITE is still rejected with 488 although chan_sip should ignore the RTP/sAVP profile and go for the RTP/AVP profile in that case.

-- 
To view, visit https://gerrit.asterisk.org/3830
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91a15ae05a0296e398d6b65f53bb11afde1d80e2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No