[Asterisk-code-review] build: Add download capability for external packages (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: build: Add download capability for external packages
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

I have not tested with Centos 7, I assume it works now?

https://gerrit.asterisk.org/#/c/3770/7/build_tools/list_valid_installed_externals
File build_tools/list_valid_installed_externals:

PS7, Line 8: script_path=$(readlink -f ${0})
           : script_dir=$(dirname ${script_path})
           : ASTTOPDIR=$(readlink -f ${script_dir}/.. )
Sorry I didn't notice this earlier, thought you removed this use of 'readlink -f'.


https://gerrit.asterisk.org/#/c/3770/5/build_tools/make_version
File build_tools/make_version:

PS5, Line 97: cd ${1}
> This is causing an error on my system (centos 7 git 1.8.3.1)
Maybe zuul/jenkins could enable one or all of the external modules for release branches to provide coverage for this sort of thing?  This would also allow the testsuite to use these external modules for basic ABI verification - verify downloaded module(s) successfully load.


-- 
To view, visit https://gerrit.asterisk.org/3770
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3dcf1289ffd3cb0bbd7dfab3cafbb87be60323a
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes