[Asterisk-code-review] Add some missing pjsip test dependencies. (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Tue Sep 6 09:25:29 CDT 2016


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: Add some missing pjsip test dependencies.
......................................................................


Add some missing pjsip test dependencies.

Change-Id: I8bc6d36f8764675d7ef4b8e4d2a6c3e43df648dd
---
M tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/test-config.yaml
M tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/test-config.yaml
M tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml
M tests/channels/pjsip/diversion/diversion_basic/test-config.yaml
M tests/channels/pjsip/diversion/diversion_request/test-config.yaml
M tests/channels/pjsip/diversion/diversion_response/test-config.yaml
M tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf
M tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml
8 files changed, 19 insertions(+), 10 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/test-config.yaml b/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/test-config.yaml
index edbe5ca..bef0a55 100644
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/test-config.yaml
+++ b/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/test-config.yaml
@@ -74,6 +74,7 @@
     dependencies:
         - sipp :
             version : 'v3.0'
+        - asterisk : 'app_dial'
         - asterisk : 'app_echo'
         - asterisk : 'app_playback'
         - asterisk : 'res_pjsip'
diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/test-config.yaml b/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/test-config.yaml
index edbe5ca..bef0a55 100644
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/test-config.yaml
+++ b/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/test-config.yaml
@@ -74,6 +74,7 @@
     dependencies:
         - sipp :
             version : 'v3.0'
+        - asterisk : 'app_dial'
         - asterisk : 'app_echo'
         - asterisk : 'app_playback'
         - asterisk : 'res_pjsip'
diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml
index f4aa325..97579a6 100644
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml
+++ b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml
@@ -42,6 +42,9 @@
     dependencies:
         - sipp :
             version : 'v3.0'
+        - asterisk : 'app_dial'
+        - asterisk : 'app_echo'
+        - asterisk : 'app_playback'
         - asterisk : 'res_pjsip'
     tags:
         - pjsip
diff --git a/tests/channels/pjsip/diversion/diversion_basic/test-config.yaml b/tests/channels/pjsip/diversion/diversion_basic/test-config.yaml
index 3de7f68..3219207 100644
--- a/tests/channels/pjsip/diversion/diversion_basic/test-config.yaml
+++ b/tests/channels/pjsip/diversion/diversion_basic/test-config.yaml
@@ -7,9 +7,10 @@
 properties:
     minversion: '12'
     dependencies:
-         - app : 'sipp'
-         - asterisk : 'res_pjsip'
-         - asterisk : 'res_pjsip_diversion'
+        - app : 'sipp'
+        - asterisk : 'app_dial'
+        - asterisk : 'res_pjsip'
+        - asterisk : 'res_pjsip_diversion'
     tags:
         - pjsip
 
diff --git a/tests/channels/pjsip/diversion/diversion_request/test-config.yaml b/tests/channels/pjsip/diversion/diversion_request/test-config.yaml
index 480dee7..9fc1d17 100644
--- a/tests/channels/pjsip/diversion/diversion_request/test-config.yaml
+++ b/tests/channels/pjsip/diversion/diversion_request/test-config.yaml
@@ -7,9 +7,10 @@
 properties:
     minversion: '12'
     dependencies:
-         - app : 'sipp'
-         - asterisk : 'res_pjsip'
-         - asterisk : 'res_pjsip_diversion'
+        - app : 'sipp'
+        - asterisk : 'app_dial'
+        - asterisk : 'res_pjsip'
+        - asterisk : 'res_pjsip_diversion'
     tags:
         - pjsip
 
diff --git a/tests/channels/pjsip/diversion/diversion_response/test-config.yaml b/tests/channels/pjsip/diversion/diversion_response/test-config.yaml
index bc8e1b9..4ce6052 100644
--- a/tests/channels/pjsip/diversion/diversion_response/test-config.yaml
+++ b/tests/channels/pjsip/diversion/diversion_response/test-config.yaml
@@ -9,9 +9,10 @@
 properties:
     minversion: '12'
     dependencies:
-         - app : 'sipp'
-         - asterisk : 'res_pjsip'
-         - asterisk : 'res_pjsip_diversion'
+        - app : 'sipp'
+        - asterisk : 'app_dial'
+        - asterisk : 'res_pjsip'
+        - asterisk : 'res_pjsip_diversion'
     tags:
         - pjsip
 
diff --git a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf
index e670885..5452642 100644
--- a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf
+++ b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf
@@ -19,6 +19,6 @@
 [other]
 ; Second test iteration should execute
 exten => charlie,1,NoOp()
-        same => n,Dial(PJSIP/charlie)
+	same => n,Dial(PJSIP/charlie)
 	same => n,Hangup()
 
diff --git a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml
index beb6e4a..701cd3d 100644
--- a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml
+++ b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml
@@ -15,6 +15,7 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
+        - asterisk : 'app_dial'
         - asterisk : 'res_pjsip'
         - sipp :
             version : 'v3.4.1'

-- 
To view, visit https://gerrit.asterisk.org/3810
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bc6d36f8764675d7ef4b8e4d2a6c3e43df648dd
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list