[Asterisk-code-review] build: Add download capability for external packages (asterisk[13])

Corey Farrell asteriskteam at digium.com
Fri Sep 2 12:24:33 CDT 2016


Corey Farrell has posted comments on this change.

Change subject: build: Add download capability for external packages
......................................................................


Patch Set 5:

> I just gave this a try. I'm not sure why, but on my system, all of
 > the external modules were default selected, despite the fact that
 > the XML in this review sets defaultenabled to "no". I had to
 > manually unselect the modules I did not want to install.
 > 
 > Other than that, everything worked well.

I suspect you had an existing menuselect.makeopts.  It's actually disabled modules that are listed in menuselect.makeopts, so when a new module is supposed to be disabled by default it is not respected unless you delete menuselect.makeopts.

-- 
To view, visit https://gerrit.asterisk.org/3769
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3dcf1289ffd3cb0bbd7dfab3cafbb87be60323a
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list