[Asterisk-code-review] sorcery: Create function ast sorcery lockable alloc. (asterisk[master])

George Joseph asteriskteam at digium.com
Thu Sep 1 09:50:37 CDT 2016


George Joseph has posted comments on this change.

Change subject: sorcery: Create function ast_sorcery_lockable_alloc.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3748/1/include/asterisk/sorcery.h
File include/asterisk/sorcery.h:

PS1, Line 995:  * \brief Allocate a generic sorcery capable object
             :  *
             :  * \param size Size of the object
             :  * \param destructor Optional destructor function
             :  *
             :  * \retval non-NULL success
             :  * \retval NULL failure
             :  */
             : void *ast_sorcery_lockable_alloc(size_t size, ao2_destructor_fn destructor, void *lockobj);
How about highlighting why and how you'd use this function instead of ast_sorcery_generic_alloc?


-- 
To view, visit https://gerrit.asterisk.org/3748
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f62f2ada64b622571950278fbb6ad57395b5d6f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list