[Asterisk-code-review] codecs.conf.sample: Add sample and option descriptions for c... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Mon Oct 31 18:52:02 CDT 2016


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4250 )

Change subject: codecs.conf.sample: Add sample and option descriptions for codec_opus
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/4250/1/configs/samples/codecs.conf.sample
File configs/samples/codecs.conf.sample:

Line 160:               ; and 100, inclusive. Higher values result in a loss resistant.
Loss resistant what?  Or do you mean more loss resistance.


Line 195: ;=============================== OPUS Examples ================================
Should these examples be commented out?


Line 200: fec=no ; Force no inband fec on the encoder (i.e don't user what's on the SDP)
don't user what's on
don't use what's in


-- 
To view, visit https://gerrit.asterisk.org/4250
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d89bb5e01d3e3b5bd78951b8dd0ff077a83dc8b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list