[Asterisk-code-review] chan dahdi: remove by name support (asterisk[master])

Tzafrir Cohen asteriskteam at digium.com
Thu Oct 27 16:03:49 CDT 2016


Hello Anonymous Coward #1000019, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/4156

to look at the new patch set (#2).

Change subject: chan_dahdi: remove by_name support
......................................................................

chan_dahdi: remove by_name support

Support for referring to DAHDI channels by logical names was added in
(FIXME: when? Asterisk 11? 1.8?) and was intended to be part of support
of refering to channels by name.

While technically usable, it has never been properly supported in
dahdi-tools, as using it would require many changes at the Asterisk
level. Instead logical mapping was added at the kernel level.

Thus it seems that refering to DAHDI channels by name is not really used
by anyone, and therefore should probably be removed.

Change-Id: I7d50bbfd9d957586f5cd06570244ef87bd54b485
---
M UPGRADE.txt
M channels/chan_dahdi.c
M configs/samples/chan_dahdi.conf.sample
3 files changed, 14 insertions(+), 97 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/56/4156/2
-- 
To view, visit https://gerrit.asterisk.org/4156
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d50bbfd9d957586f5cd06570244ef87bd54b485
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list