[Asterisk-code-review] pjproject bundled: Remove usage of tar's --strip-components... (asterisk[master])

Corey Farrell asteriskteam at digium.com
Thu Oct 27 10:49:03 CDT 2016


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4201 )

Change subject: pjproject_bundled:  Remove usage of tar's --strip-components option
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4201/2/third-party/pjproject/Makefile
File third-party/pjproject/Makefile:

Line 4: export PJDIR := $(shell pwd -P)/source
This does not solve ASTERISK-22480.

The problem is that build.mak sets PJDIR with an absolute path and the very next line is a non-optional include using $(PJDIR).


-- 
To view, visit https://gerrit.asterisk.org/4201
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ec92952507a91ff4e4d01e0149e09fd8e8f32b0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list