[Asterisk-code-review] res/stasis: Add CLI commands for displaying/debugging ARI apps (asterisk[13])
Mark Michelson
asteriskteam at digium.com
Thu Oct 20 15:11:19 CDT 2016
Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4164 )
Change subject: res/stasis: Add CLI commands for displaying/debugging ARI apps
......................................................................
Patch Set 2:
I can't really see anything wrong with the patch as you've provided it.
I have a suggested addition though. In res/ari/ari_websockets.c, remove the ast_debug line that outputs the ARI event being sent on the websocket. The new CLI-enabled debug supersedes this, and if someone were to set core debug to a high level and turn on the CLI command, there would be a lot of redundant messages in the logs.
--
To view, visit https://gerrit.asterisk.org/4164
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51ad6ff0cabee0d69db06858c13f18b1c513c9f5
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No
More information about the asterisk-code-review
mailing list