[Asterisk-code-review] ARI: Detect duplicate channel IDs (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4150 )

Change subject: ARI: Detect duplicate channel IDs
......................................................................


Patch Set 2:

> > (1 comment)
 > 
 > The alternative would be to call ast_channel_callback() directly
 > instead of ast_channel_get_by_name()

I think as long as we're absolutely sure it is okay to lock it recursively in the scenario and it's documented in the code with it then get_by_name is okay. I'd prefer to not recursively lock though.

-- 
To view, visit https://gerrit.asterisk.org/4150
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibba7ae68842dab6df0c2e9c45559208bc89d3d06
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No