[Asterisk-code-review] cdr raidus,cel radius: Fix old memleak in unload (asterisk[master])

Badalian Vyacheslav asteriskteam at digium.com
Wed Oct 19 23:30:12 CDT 2016


Badalian Vyacheslav has posted comments on this change. ( https://gerrit.asterisk.org/4059 )

Change subject: cdr_raidus,cel_radius: Fix old memleak in unload
......................................................................


Patch Set 3:

- Calling rc_openlog we assigns a new name for
the channel syslog. This unexpected behavior for logger.c.

Most lesser evil, is to agree on a NULL name syslog
if the channel was not launched in logger.c.

Summary - calling rc_openlog REDEFINE asterisk SysLog!

 void rc_openlog(char const *ident)
   28 {
   29 #ifndef _MSC_VER /* TODO: Fix me */
   30     openlog(ident, LOG_PID, RC_LOG_FACILITY);
   31 #endif
   32 }

-- 
To view, visit https://gerrit.asterisk.org/4059
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17c38de67583e971d78fe18807d1a9faf8f0afd
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list