[Asterisk-code-review] chan pjsip: segfault on already disconnected session (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/4142 )

Change subject: chan_pjsip: segfault on already disconnected session
......................................................................


Patch Set 1:

> If session_inv_on_tsx_state_changed is called in the monitor thread
 > why can't it increment the INVITE session reference count before
 > queueing up session_end_completion, and decrement it in that task?
 > That would ensure before that task runs the INVITE session would
 > remain valid and complete. Same goes for other places where the
 > session end is queued up.

I don't understand how session_end_completion is connected to the tasks: answer, indicate and update_connected_line_information.

All these tasks could be placed into the serializer independently and simultaneously.
So we have to increase the counter for every tasks.

-- 
To view, visit https://gerrit.asterisk.org/4142
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2e3e2f75358cdb530252a9ce158af3d5d9fdf33
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No