[Asterisk-code-review] chan sip: Support nat=auto comedia or nat=force rport,auto c... (asterisk[11])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4069 )

Change subject: chan_sip: Support nat=auto_comedia or nat=force_rport,auto_comedia.
......................................................................


Patch Set 1:

> As external contributor, which motivation do I have to change
 > CHANGES … guys, I love to help and contribute but when you are
 > suggesting something, please, be as concrete as possible. For
 > example, which wording could be used for an interested reader. Even
 > a first shot would help (or even better, take over the commit and
 > add that).
 > 
 > Here, this change fixes a regression which was introduced with a
 > previous change. This is not a new feature or a different
 > interpretation of the documentation. This worked once in a time and
 > is the expected behavior. These two cases were not tested and
 > slipped through.

I was mixed up with a different change, please ignore my last message.

-- 
To view, visit https://gerrit.asterisk.org/4069
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib29d66c6dbb61648e371e01fc36c6978ddae5bc2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No