[Asterisk-code-review] release summary: Add issues with no component to General (repotools[master])

Joshua Colp asteriskteam at digium.com
Mon Oct 17 10:44:30 CDT 2016


Joshua Colp has submitted this change and it was merged.

Change subject: release_summary:  Add issues with no component to General
......................................................................


release_summary:  Add issues with no component to General

Issues with no component set are now considered as belonging to the
General component to insure they're captured in the release summaries.

Jira isn't updated.  This is just internal to the script.

Change-Id: Iffad8cde8461d58392c6355b3934a37e9d799d21
---
M release_summary.py
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/release_summary.py b/release_summary.py
index 9452404..27d2fdd 100755
--- a/release_summary.py
+++ b/release_summary.py
@@ -408,8 +408,11 @@
         components = {}
         # Build up a list of components
         for issue in issues:
-            for component in issue.fields.components:
-                components.setdefault(component.name, list()).append(issue)
+            if not issue.fields.components or len(issue.fields.components) == 0:
+                components.setdefault("General", list()).append(issue)
+            else:
+                for component in issue.fields.components:
+                    components.setdefault(component.name, list()).append(issue)
 
         html.h3(issue_type)
         for key in sorted(components):

-- 
To view, visit https://gerrit.asterisk.org/4119
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iffad8cde8461d58392c6355b3934a37e9d799d21
Gerrit-PatchSet: 1
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list