[Asterisk-code-review] chan pjsip: segfault on hangup (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_pjsip: segfault on hangup
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4085/1//COMMIT_MSG
Commit Message:

Line 10: When this task is popped from the serializer an ast_channel
Can you provide further information besides the backtrace (a full backtrace would also be good) such as console log, etc, to show this?

A hangup is queued from the chan_pjsip_hangup function which guarantees ast to be valid and non-NULL. As well the hangup data structure holds a reference to the channel itself, to guarantee that it wont' get destroyed until after hangup is run.

I think there's another off nominal or different problem here and don't believe this is the correct way to fix it.


-- 
To view, visit https://gerrit.asterisk.org/4085
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I702faac011819b37a430b710468782fc16154cc9
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes