[Asterisk-code-review] Fix issues with bundled pjproject cached download. (asterisk[14])

George Joseph asteriskteam at digium.com
Fri Oct 14 07:48:23 CDT 2016


Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/4108

to look at the new patch set (#2).

Change subject: Fix issues with bundled pjproject cached download.
......................................................................

Fix issues with bundled pjproject cached download.

Previously when testing I had a preexisting makeopts in ASTTOPDIR.  The
ordering of configure.ac causes --with-externals-cache to be processed
after third-party configure.  In cases where the Asterisk clone is
cleaned it would cause pjproject to be downloaded to /tmp.  This
moves processing of the externals cache and sounds cache to happen
before third-party configure.

This also addresses a possible issue with the third-party Makefile.  If
TMPDIR is set by the environment it would override the path given to
--with-externals-cache.

ASTERISK-26416

Change-Id: Ifab7f35bfcd5a31a31a3a4353cc26a68c8c6592d
---
M configure
M configure.ac
M third-party/pjproject/Makefile
M third-party/pjproject/configure.m4
4 files changed, 66 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/08/4108/2
-- 
To view, visit https://gerrit.asterisk.org/4108
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifab7f35bfcd5a31a31a3a4353cc26a68c8c6592d
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>



More information about the asterisk-code-review mailing list