[Asterisk-code-review] Binaural synthesis (confbridge): On/off setting for binaural... (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: Binaural synthesis (confbridge): On/off setting for binaural synthesis.
......................................................................


Patch Set 3:

(2 comments)

Looks like you've got a merge conflict.  Can you update the patch set with the conflict resolved?

https://gerrit.asterisk.org/#/c/3523/2/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

Line 288: 					<synopsis>If true binaural conferencing with stereo opus is active</synopsis>
Probably want to update the docs so that it says "stereo audio" versus "stereo opus".


Line 1938: 				| BRIDGE_OPT_VIDEO_SRC_LAST_MARKED
This probably doesn't need to be numerical, does it?  More of a true/false test instead versus numerical parsing.


-- 
To view, visit https://gerrit.asterisk.org/3523
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59dfcb8e55fe1df4ef32045882fea5bb58fc71db
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes