[Asterisk-code-review] bundled pjproject: Add tests for programs used by the Makef... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: bundled_pjproject:  Add tests for programs used by the Makefile, et al.
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

This review is already +2'd, nothing I've found is important enough to stop this patch.

https://gerrit.asterisk.org/#/c/4014/3/third-party/pjproject/Makefile
File third-party/pjproject/Makefile:

Line 23:     include ../../makeopts
Any reason you didn't just use '-include ../../makeopts'?  Would this cause 'make' to try building makeopts or something weird like that?


https://gerrit.asterisk.org/#/c/4014/3/third-party/pjproject/configure.m4
File third-party/pjproject/configure.m4:

Line 12: 	
Red


-- 
To view, visit https://gerrit.asterisk.org/4014
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1d94251c0155f8dd41b7de7067f35cfbaafbb9b
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes