[Asterisk-code-review] vector: After remove element recheck index (asterisk[13])
Kevin Harwell
asteriskteam at digium.com
Mon Oct 10 18:27:40 CDT 2016
Kevin Harwell has posted comments on this change.
Change subject: vector: After remove element recheck index
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.asterisk.org/#/c/4067/3/include/asterisk/vector.h
File include/asterisk/vector.h:
Line 370: for (idx = ((vec)->current - 1); idx >= 0; --idx) { \
> Where is the problem?
> Where is the problem?
No problem, you are correct. For some reason I was thinking the last value could get moved before the index, but that is not the case.
--
To view, visit https://gerrit.asterisk.org/4067
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib947fa94dc91dcd9341f357f1084782c64434eb7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list