[Asterisk-code-review] vector: After remove element recheck index (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: vector: After remove element recheck index
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Giving a -1 because I'd like to see some tests cases for this functionality added to the unit tests in tests/test_vector.c

https://gerrit.asterisk.org/#/c/4067/3/include/asterisk/vector.h
File include/asterisk/vector.h:

Line 370: 	for (idx = ((vec)->current - 1); idx >= 0; --idx) {		\
Not a huge deal (just less optimized), but wouldn't this result in elements potentially getting checked multiple times? Same for the ordered list too.


-- 
To view, visit https://gerrit.asterisk.org/4067
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib947fa94dc91dcd9341f357f1084782c64434eb7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes