[Asterisk-code-review] pjsip: Support dual stack automatically. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: pjsip: Support dual stack automatically.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

This seems to make multi-home almost a required dependency in order for res_pjsip to function correctly/reasonably. If that is the case I lean toward making these changes part of the core.

On the other hand it seems to fit in with minimal changes to the multi-home code. But does it change the definition somewhat of what multi-home is?

However, if left in multi-home I would like to see more robust default behavior for the other modules if multi-home does not get loaded. For instance do the other modules default to just use ipv4 or ipv6? Maybe have a warning message? Leave the code that was previously there, but override if multi-home is loaded? Thoughts?

https://gerrit.asterisk.org/#/c/3977/3/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

Line 1120: 	media->conn->addr_type = STR_IP4;
What happens for the address if the multi-home module does not or is not loaded? Here the type is set to ipv4, but below on module load the default rtp address is ipv6.


-- 
To view, visit https://gerrit.asterisk.org/3977
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I235a421d8f9a326606d861b449fa6fe3a030572d
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes