[Asterisk-code-review] res pjsip session: Send request even if the state is disconn... (asterisk[master])

Yaacov Akiba Slama asteriskteam at digium.com
Mon Oct 10 05:08:26 CDT 2016


Yaacov Akiba Slama has posted comments on this change.

Change subject: res_pjsip_session: Send request even if the state is disconnected
......................................................................


Patch Set 2:

Joshua, in fact outbound_invite_auth is not even called in this scenario. It seems to me that the simplest fix is what I proposed in the pjsip mailing list http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2016-September/019541.html IMHO, it's the right fix because it's not valid to close the session if the BYE was not ack'ed by the trunk.

-- 
To view, visit https://gerrit.asterisk.org/3886
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7254684dc07bc739c10597f3bec92f470eace137
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Yaacov Akiba Slama <yaslama at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Yaacov Akiba Slama <yaslama at gmail.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list