[Asterisk-code-review] alembic: Allow cdr, config and voicemail to exist in the sa... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: alembic:  Allow cdr, config and voicemail to exist in the same schema
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

Typos and formatting.  Can't say much else about python. :)

https://gerrit.asterisk.org/#/c/4018/1/contrib/ast-db-manage/cdr/env.py
File contrib/ast-db-manage/cdr/env.py:

Line 76:     """ If there was an existing alembic_version table, we we need to
we we
oui oui


Line 82:             """ An alembic_versions table was found and it belongs to this alembic tree """
Do we care about PEP8 compliance?  This and a few other lines are too long for PEP8.


https://gerrit.asterisk.org/#/c/4018/1/contrib/ast-db-manage/config/env.py
File contrib/ast-db-manage/config/env.py:

Line 76:     """ If there was an existing alembic_version table, we we need to
we we


Line 82:             """ An alembic_versions table was found and it belongs to this alembic tree """
PEP8 line lengths


https://gerrit.asterisk.org/#/c/4018/1/contrib/ast-db-manage/voicemail/env.py
File contrib/ast-db-manage/voicemail/env.py:

Line 76:     """ If there was an existing alembic_version table, we we need to
we we


Line 82:             """ An alembic_versions table was found and it belongs to this alembic tree """
PEP8 line lengths


-- 
To view, visit https://gerrit.asterisk.org/4018
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d593f000350deb5d21a14fa1e9bc3896844d898
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes