[Asterisk-code-review] chan sip: Honor support of Symmetric Response (rport) for SI... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: chan_sip: Honor support of Symmetric Response (rport) for SIP requests.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/4027/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 16757: 	    (!ast_test_flag(&peer->flags[0], SIP_NAT_FORCE_RPORT) && !ast_test_flag(&pvt->flags[0], SIP_NAT_RPORT_PRESENT))) {
> parse_register_contact(.) is called at two different places: In one case, S
Thank you for explaining. I've opened ASTERISK-26477 for documenting the correct usage of these flags.


-- 
To view, visit https://gerrit.asterisk.org/4027
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6e7891848aaf96666dee5305695f7c6667cd5a6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes