[Asterisk-code-review] pjproject bundled: Add MALLOC DEBUG capability (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: pjproject_bundled:  Add MALLOC_DEBUG capability
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/4030/1/third-party/pjproject/Makefile
File third-party/pjproject/Makefile:

Line 64: MULDEFS=-Wl,-z,muldefs
If you're keeping this error suppression can we put the conditional here (the multi-line ifeq form)?  So if MALLOC_DEBUG is not enabled MULDEFS should be blank.

Will be easier to read that way instead of using the $(if ...) in the pjsua rule below.


Line 121: source/pjsip-apps/bin/pjsua-$(TARGET_NAME): LDFLAGS += $(if $(findstring MALLOC_DEBUG,$(MENUSELECT_CFLAGS)),$(MULDEFS))
What symbol gets duplicated?  Can't we solve this with an #if conditional block to suppress the duplicates?

I feel like this MULDEFS linker flag is suppressing an actual error that should be fixed.


https://gerrit.asterisk.org/#/c/4030/1/third-party/pjproject/patches/asterisk_malloc_debug.h
File third-party/pjproject/patches/asterisk_malloc_debug.h:

Line 41:  * and pjsystest applications.  The pjproject libraries will get them from asterisk.
Please comment on how the python bindings will work.


-- 
To view, visit https://gerrit.asterisk.org/4030
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc5e3d658fbfb00e0a46b44c66dcc2522d5171b0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes