[Asterisk-code-review] Binaural synthesis (confbridge): interleaved two-channel audio. (asterisk[master])

[Dennis Guse]

Dennis Guse has posted comments on this change.

Change subject: Binaural synthesis (confbridge): interleaved two-channel audio.
......................................................................


Patch Set 1:

(1 comment)

Added comments

https://gerrit.asterisk.org/#/c/3521/1/main/channel.c
File main/channel.c:

Line 5544: 			trans_pvt->interleaved_stereo = 0;
> Do we not care about read?
In case of binaural rendering: no.
Even if interleaved stereo would be received by Asterisk, only one mono signal would be used for the binaural rendering.
Thus, only writing interleaved stereo is required and actual reading can be omitted.

This might however be different for other use cases...


-- 
To view, visit https://gerrit.asterisk.org/3521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a547cea0fd3c6d1e502709d9e7e39605035757a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes