[Asterisk-code-review] res rtp: Fix regression when IPv6 is not available. (asterisk[master])

Alexei Gradinari asteriskteam at digium.com
Wed Nov 30 12:57:07 CST 2016


Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/4487 )

Change subject: res_rtp: Fix regression when IPv6 is not available.
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.asterisk.org/#/c/4487/9/include/asterisk/utils.h
File include/asterisk/utils.h:

Line 850: int ast_check_ipv6(void);
I think better to add function declaration to the end of the file.

You should comply the format of comments.
Example:
/*
 * \brief Test that an OS supports IPv6 Networking.
 * \since 13.14.0
 * 
 * \return True (non-zero) if the IPv6 supported.
 * \return False (zero) if the OS doesn't support IPv6.
 */


-- 
To view, visit https://gerrit.asterisk.org/4487
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627a4e91795e821111e1cda523f083a40d0e0c3e
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list