[Asterisk-code-review] PJPROJECT logging: Made easier to get available logging levels. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4515 )

Change subject: PJPROJECT logging: Made easier to get available logging levels.
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/4515/3/configs/samples/pjproject.conf.sample
File configs/samples/pjproject.conf.sample:

PS3, Line 4: boot
I think "boot" is a little misleading.  In keeping with the rest of asterisk, I think "general" or "global" would be more appropriate.


https://gerrit.asterisk.org/#/c/4515/3/main/asterisk.c
File main/asterisk.c:

Line 651: 	ast_cli(a->fd, "  Pjproject log level:         %d\n", ast_option_pjproject_log_level);
This should be moved to "pjproject show".


https://gerrit.asterisk.org/#/c/4515/3/res/res_pjproject.c
File res/res_pjproject.c:

PS3, Line 44: boot
See earlier comment.


-- 
To view, visit https://gerrit.asterisk.org/4515
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dca12979f482ffb0450aaf58db0fe0f6d2e5389
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes