[Asterisk-code-review] Experimental patch to add RTCP feedback to codec modules (asterisk[14])

Richard Mudgett asteriskteam at digium.com
Tue Nov 29 11:26:26 CST 2016


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4521 )

Change subject: Experimental patch to add RTCP feedback to codec modules
......................................................................


Patch Set 1: Code-Review-1

Stop messing with the Change-Id.  The Change-Id must NOT change for a review.  The Change-Id is how Gerrit associates your change with a review.  As it now stands you have THREE different reviews posted for the same patch.

You also do not need to put in a change history in the commit message as Gerrit knows how to handle review versions.  You should amend your patch and repost.

-- 
To view, visit https://gerrit.asterisk.org/4521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd6aa77fb4a7ff546c6025900fc2baf332c31857
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Lorenzo Miniero <lminiero at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list