[Asterisk-code-review] res calendar caldav: Add support reading gmail calendar (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change. ( https://gerrit.asterisk.org/4518 )

Change subject: res_calendar_caldav: Add support reading gmail calendar
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4518/1/res/res_calendar_caldav.c
File res/res_calendar_caldav.c:

PS1, Line 497: 	if (xmlStrcasecmp(name, BAD_CAST "C:calendar-data")) {
             : 		if (xmlStrcasecmp(name, BAD_CAST "caldav:calendar-data")) {
             : 			return;
             : 		}
             : 	}
Go ahead and use a Boolean AND here:

if (xmlStrcasecmp(name, BAD_CAST "C:calendar-data") && xmlStrcasecmp(name, BAD_CAST "caldav:calendar-data")) {
   ...
}


-- 
To view, visit https://gerrit.asterisk.org/4518
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1eef10552ae616efb645d390f5ffe81260d7d4a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Eduardo Scudeller Libardi <eslibardi at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes