[Asterisk-code-review] Binaural synthesis (confbridge): Adds binaural synthesis to ... (asterisk[master])

Dennis Guse asteriskteam at digium.com
Mon Nov 28 15:11:18 CST 2016


Dennis Guse has posted comments on this change. ( https://gerrit.asterisk.org/3524 )

Change subject: Binaural synthesis (confbridge): Adds binaural synthesis to bridge_softmix.
......................................................................


Patch Set 15: Code-Review-1

Cleanup:
* removed impulse responses
* add generator for hrirs.h (utils/conf_bridge_binaural_hrir_importer.c)
* configure checks for existence of hrirs.h and binaural is disabled if not available
* removed old files
* added sanity checks (e.g., impulse response sampling rate)

Issues:
* utils/conf_bridge_binaural_hrir_importer.c requires libsndfile
* This patch set does not address the mutex question (Joshua's comment)
* This patch set does the header file question (Joshua's comment)
* This patch compiles, but was not tested

-- 
To view, visit https://gerrit.asterisk.org/3524
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecdb381b6adc17c961049658678f6219adae1ddf
Gerrit-PatchSet: 15
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list