[Asterisk-code-review] tcptls: Use new certificate upon sip reload (asterisk[13])

[Michael Kuron]

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/4448 )

Change subject: tcptls: Use new certificate upon sip reload
......................................................................


Patch Set 8:

Ok, thanks.

There is one slightly hacky way to check for the ABI breakage at runtime so we can show a warning and revert back to the old behavior: malloc_usable_size() (or malloc_size() on BSD) can tell you the size of an allocation (or a few bytes more than that), so we'd know whether the allocation was made per the old or new struct sizes. Unfortunately, these functions are not in the POSIX standard, but they are supported on all major platforms. If they are not present, we could still fall back to the old behavior of not reloading the TLS certificate.

I'm not saying we should do it like that, just wanted to provide an idea in case somebody objects to the ABI breakage on the mailing list. Also, I guess it wouldn't matter on the master branch.

-- 
To view, visit https://gerrit.asterisk.org/4448
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e86cefc6dcd627c915134015a6a1ab1aadbe6
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No