[Asterisk-code-review] res rtp: Fix regression observed in FreeBSD when IPv6 is not... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4487 )

Change subject: res_rtp: Fix regression observed in FreeBSD when IPv6 is not available.
......................................................................


Patch Set 4: Code-Review-1

I don't think this is the right place to fix this and also not the right way.

Falling back to IPv4 requires explicit support for doing so by the caller and user of both the UDPTL and RTP stack. It should only be done by the user of those APIs.

To that end I think the correct fix (which would also cover Linux compiled without IPv6) would be done in res_pjsip_sdp_rtp and res_pjsip_t38. 

Using the PJSIP method (sip_check_transport in res/res_pjsip/pjsip_resolver.c in 14) for retrieving transport information each can determine if any IPv6 PJSIP transport is configured on the system. If so then the address used can be "::". If not then it can fallback to "0.0.0.0". Since it would be impossible to configure and use a PJSIP transport with IPv6 on a system that has no IPv6 support this would serve as a way to know.

-- 
To view, visit https://gerrit.asterisk.org/4487
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627a4e91795e821111e1cda523f083a40d0e0c3e
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No