[Asterisk-code-review] Binaural synthesis (confbridge): Adds binaural synthesis to ... (asterisk[master])

[Frank Haase]

Frank Haase has posted comments on this change. ( https://gerrit.asterisk.org/3524 )

Change subject: Binaural synthesis (confbridge): Adds binaural synthesis to bridge_softmix.
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

Minor changes, still marked as -1 per -dev discussion.

https://gerrit.asterisk.org/#/c/3524/3/include/asterisk/interleaved_stereo.h
File include/asterisk/interleaved_stereo.h:

PS3, Line 10: PLACEHOLDER_STEREO_CODEC
> What's the purpose of this placeholder?
Our patch was originally build with Opus, but since there are some issues with patents we could not implement it.
We didn't found another multi channel audio codec yet.
My colleague Dennis Guse will be at AstriCon, maybe you can discuss this in detail.
Solutions would be either Opus as binary and simply change the string to "opus" (plus a check of attr->stereo is true) or finding another codec.


-- 
To view, visit https://gerrit.asterisk.org/3524
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecdb381b6adc17c961049658678f6219adae1ddf
Gerrit-PatchSet: 12
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes