[Asterisk-code-review] pbx lua: On configuration errors report module load failure ... (asterisk[master])

[Dennis Guse]

Dennis Guse has posted comments on this change. ( https://gerrit.asterisk.org/4493 )

Change subject: pbx_lua: On configuration errors report module load failure instead of decline.
......................................................................


Patch Set 2:

Tested (all modules marked as required)

* pbx_config:
** missing config file: not reported
** syntax error: warning

* pbx_ael:
** missing config file: notice
** syntax error: error

* pbx_lua (old behavior):
** missing config file: warning
** syntax error: warning

* pbx_lua (new behavior):
** missing config file: warning
** syntax error: stop asterisk

So, consistency is not there at the moment ;)
The tested modules (old behavior) ignore modules.conf required flag (i.e. asterisk starts although modules could not be loaded).
Should we move this to the mailing list?

-- 
To view, visit https://gerrit.asterisk.org/4493
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e5a0037e69b41743db60c568541ebb2f52a7a8f
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No