[Asterisk-code-review] Binaural synthesis (confbridge): Adds binaural synthesis to ... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/3524 )

Change subject: Binaural synthesis (confbridge): Adds binaural synthesis to bridge_softmix.
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.asterisk.org/#/c/3524/11/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

Line 131: 	//when we have binaural audio we can't do the saturated substract
we don't use // comments


https://gerrit.asterisk.org/#/c/3524/11/bridges/bridge_softmix/include/bridge_softmix_internal.h
File bridges/bridge_softmix/include/bridge_softmix_internal.h:

Line 1: /*
Are all of the values you extracted and put into this header file applicable to all the files that include them, or are some implementation specifics to those files and shouldn't be shared?


-- 
To view, visit https://gerrit.asterisk.org/3524
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecdb381b6adc17c961049658678f6219adae1ddf
Gerrit-PatchSet: 11
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes