[Asterisk-code-review] app originate: Add option to execute gosub prior to dial (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4484 )

Change subject: app_originate: Add option to execute gosub prior to dial
......................................................................


Patch Set 1: Code-Review-1

(9 comments)

https://gerrit.asterisk.org/#/c/4484/1/CHANGES
File CHANGES:

Line 64:    
Extra redness


https://gerrit.asterisk.org/#/c/4484/1/apps/app_originate.c
File apps/app_originate.c:

Line 217: 		ast_debug(1, "Predial caller '%s' \n",opt_args[OPT_ARG_PREDIAL_CALLER]);
Can this debug message be extended to be a bit more useful? Extension/dialed thing? Same for below debug message


Line 220: 	
Redness


Line 227: 	
Redness


https://gerrit.asterisk.org/#/c/4484/1/include/asterisk/pbx.h
File include/asterisk/pbx.h:

Line 1179: int __ast_pbx_outgoing_exten(const char *type, struct ast_format_cap *cap, const char *addr,
The prefix __ is generally used to indicate an internal API function at times. This should not be prefixed, perhaps add with_predial to the end of the name?


Line 1220: int __ast_pbx_outgoing_app(const char *type, struct ast_format_cap *cap, const char *addr,
Same here


https://gerrit.asterisk.org/#/c/4484/1/main/pbx.c
File main/pbx.c:

Line 7641: 	
Redness


Line 7666: 	
Redness


Line 7667: 	if (predial_callee) {
Should this use ast_strlen_zero instead?


-- 
To view, visit https://gerrit.asterisk.org/4484
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36abc39b58567ffcab4a636ea196ef48be234c57
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: David Kerr <david at kerr.net>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes