[Asterisk-code-review] res rtp asterisk: RTT miscalculation in RTCP (asterisk[13])

[Hector Royo Concepcion]

Hector Royo Concepcion has posted comments on this change. ( https://gerrit.asterisk.org/4397 )

Change subject: res_rtp_asterisk: RTT miscalculation in RTCP
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/4397/2/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

PS2, Line 4058: rtt_tv.tv_usec = (rtt_lsw * 15625) >> 10;
I tested this patch and it works OK.

I created a snippet of the code you proposed and used the values of 'Example for round-trip time computation'present on RTCP RFC(1889, 6.3.2). Results were correct.

Then I compiled an Asterisk 13.11.2 with this patch, and made some test calls. The RTT values I'm getting from Asterisk and Wireshark are the same. I'm getting 2-5ms for local calls and 65-70ms for calls over trunk, which seems reasonable to me.


-- 
To view, visit https://gerrit.asterisk.org/4397
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie09bdabfee75afb3f1b8ddfd963e5219ada3b96f
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Hector Royo Concepcion <hectorroyo92 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Hector Royo Concepcion <hectorroyo92 at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes