[Asterisk-code-review] res rtp asterisk: RTT miscalculation in RTCP (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4397 )

Change subject: res_rtp_asterisk: RTT miscalculation in RTCP
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4397/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 4025: 	rtt_tv.tv_usec = ((rtt_lsw*999985)/65535);
rtt_lsw is a 16 bit quantity and multiplying it by 999985 (a 20 bit quantity) can result in a value that needs 36 bits and thus we still have an overflow problem in the code.

@Hector: I'll update the patch.  You need to test that it still works.


-- 
To view, visit https://gerrit.asterisk.org/4397
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie09bdabfee75afb3f1b8ddfd963e5219ada3b96f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Hector Royo Concepcion <hectorroyo92 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes