[Asterisk-code-review] tcptls: Use new certificate upon sip reload (asterisk[13])

Michael Kuron asteriskteam at digium.com
Mon Nov 21 15:57:32 CST 2016


Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/4448 )

Change subject: tcptls: Use new certificate upon sip reload
......................................................................


Patch Set 5:

Thanks for the comments, which I've addressed in the latest patch set. I noticed that I was also using strncmp/strncpy for the SHA1 hashes and replaced that with memcmp/memcpy because the hashes can contain null bytes. The cherry-picks are also up-to-date now.

-- 
To view, visit https://gerrit.asterisk.org/4448
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e86cefc6dcd627c915134015a6a1ab1aadbe6
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list