[Asterisk-code-review] Testsuite: avoid accidental use of alternate tmp (testsuite[master])

Corey Farrell asteriskteam at digium.com
Mon Nov 21 09:44:38 CST 2016


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4452 )

Change subject: Testsuite: avoid accidental use of alternate tmp
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4452/2/lib/python/asterisk/asterisk.py
File lib/python/asterisk/asterisk.py:

Line 319:         difference = os.statvfs(y).f_bavail - os.statvfs(x).f_bavail
Why not compare the device id's to check for the same FS?

if os.stat(y).st_dev == os.stat(x).st_dev:
    return 0

Available space only needs to be checked/compared if st_dev is different.


-- 
To view, visit https://gerrit.asterisk.org/4452
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bc3ded873e917960478f31c257c93cd28fb4aa
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list